Type LPage and users #1404
Merged
Type LPage and users #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uncovered an inconstency in our API where we used the result of a void function. Explicitly added a `null` return to keep our current behavior. TEST=Tested all the proofing buttons (save, mark as bad, ...).
cpeel
approved these changes
Dec 21, 2024
srjfoo
approved these changes
Dec 23, 2024
70ray
approved these changes
Dec 23, 2024
| @@ -866,7 +866,8 @@ function api_v1_project_page(string $method, array $data, array $query_params) | |||
| case 'revert': | |||
| return $proof_project_page->save_and_revert(receive_project_text_from_request_body('text')); | |||
There was a problem hiding this comment.
(I spotted my earlier mistake here with the text parameter. I'll make a PR to fix it after this so it doesn't conflict.)
chrismiceli
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uncovered an inconstency in our API where we used the result of a void function. Explicitly added a
nullreturn to keep our current behavior.TEST=Tested all the proofing buttons (save, mark as bad, ...).
Sandbox: https://www.pgdp.org/~jchaffraix/c.branch/julien_type_LPage_all/